Merged
Conversation
jacobtylerwalls
requested changes
Jul 4, 2023
Member
jacobtylerwalls
left a comment
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Let's merge the last two PRs on the milestone, they're both unreleased bug fixes and we really need at least the crash fix.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2236 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 94 94
Lines 10930 10930
=======================================
Hits 10146 10146
Misses 784 784
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
approved these changes
Jul 4, 2023
Member
jacobtylerwalls
left a comment
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Great! Everything will be correct when these are rebased, yeah?
Member
|
Btw, I think Marc was hoping that an entire astroid alpha would be devoted to just #1867, so that's why I created a new milestones for that PR only. There's some merge conflicts after the inference module was removed; I should be able to push some changes to his branch and review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.